Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the java executable location logic, #241 #1452

Merged
merged 6 commits into from
Mar 13, 2019
Merged

Improve the java executable location logic, #241 #1452

merged 6 commits into from
Mar 13, 2019

Conversation

starksm64
Copy link
Contributor

@starksm64 starksm64 commented Mar 13, 2019 •
edited
Loading

Here is an initial update the the DevMojo logic for locating the java binary to address #241 . It allows for use of the maven toolchains as well as fallback to java.home and then the path. I have tested it on osx and windows.

@gsmet
Copy link
Member

gsmet commented Mar 13, 2019

@starksm64 could you rebase? We merged a previous PR and they are conflicting on the MavenSession declaration. Thanks.

@stuartwdouglas
Copy link
Member

This needs a rebase as the other PR got merged

@gsmet gsmet added the triage/needs-rebase This PR needs to be rebased first because it has merge conflicts label Mar 13, 2019
@starksm64
Copy link
Contributor Author

Working on rebase.

@starksm64 starksm64 removed the triage/needs-rebase This PR needs to be rebased first because it has merge conflicts label Mar 13, 2019
@starksm64
Copy link
Contributor Author

So this is failing due to a formatting validation:

2019-03-13T14:06:23.3106300Z [ERROR] Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.8.1:validate (default) on project quarkus-maven-plugin: File '/home/vsts/work/1/s/devtools/maven/src/main/java/io/quarkus/maven/DevMojo.java' has not been previously formatted.  Please format file and commit before running validation! -> [Help 1]

I have the eclipse formatter plugin installed, not sure why the code was not formatted correctly. I just pushed a reformat update.

@starksm64
Copy link
Contributor Author

Same problem, so I checked my formatting settings and found that it was not on this project. Trying again.

@starksm64 starksm64 merged commit 48554e2 into quarkusio:master Mar 13, 2019
@gsmet gsmet added this to the 0.12.0 milestone Mar 15, 2019
@paschm paschm mentioned this pull request Oct 27, 2020
Open
maxandersen pushed a commit to maxandersen/quarkus that referenced this pull request Nov 5, 2022
@quintesse
fix: Fixed NPE when running info on a JAR file (quarkusio#1452)
10426e9 
Fixes quarkusio#1451
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@starksm64 @gsmet @stuartwdouglas @cescoffier